Support a context option to be posted back by browse-everything #68
Conversation
|
This probably should have been a separate PR, and I'll cherry-pick it out if someone really wants me to, but I also made the browser pretty. |
|
@mbklein should |
| @@ -8,4 +8,11 @@ def array_to_hidden_fields(array,key) | |||
| fields.join("\n").html_safe | |||
| end | |||
|
|
|||
| def is_acceptable?(file) | |||
| file_type = file.type | |||
There was a problem hiding this comment.
Totally pedantic but what's the purpose of this variable? It seems like file_type is only used once below, and isn't conveying any information that isn't in the method name on the object (file.type).
|
Self-merging to save anyone else the shame and disappointment if anything breaks. :) |
Support a context option to be posted back by browse-everything
| @@ -0,0 +1,18 @@ | |||
| <% unless file.name =~ /^\.+$/ %> | |||
There was a problem hiding this comment.
What is the file object in this context? I wonder if there isn't some sort of method on the file object (or one we can add) that can tell us this information. (which I think is to not do this for the parent/self directory pointers?)
|
|
|
Sorry. Yes, you're right about the purpose of that kludge. I'll add that before the release. |
|
@jkeck I owe you a beer for the unreviewed merge. :) |
|
@mbklein no worries. Sorry I dragged my feed so long on actually getting around to looking at it. |
Allows a
data-contextoption to be added to the trigger button (or acontextkey added to the options passed to$().browseEverything()) that will be passed back to the server whenever the user navigates to a new provider or folder, or when the submit button is clicked. This will allow an application-suppliedbefore_filterto alter the server-side, request-specific browse configuration before the request is handled (e.g., to allow the file_system handler to point to a different location).