Merge pull request #144 from projecthydra/trailing_slash

Add trailing slashes to geonames uris
samvera · May 1, 2017 · 3720265 · 3720265
2 parents 62f1b1b + 895b3d2
commit 3720265
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/qa/authorities/geonames.rb b/lib/qa/authorities/geonames.rb
@@ -38,7 +38,8 @@ def find_url(id)
       # Reformats the data received from the service
       def parse_authority_response(response)
         response['geonames'].map do |result|
-          { 'id' => "http://sws.geonames.org/#{result['geonameId']}",
+          # Note: the trailing slash is meaningful.
+          { 'id' => "http://sws.geonames.org/#{result['geonameId']}/",
             'label' => label.call(result) }
         end
       end

diff --git a/spec/lib/authorities/geonames_spec.rb b/spec/lib/authorities/geonames_spec.rb
@@ -28,9 +28,9 @@
 
       context "with default label" do
         it "has id and label keys" do
-          expect(subject.first).to eq("id" => 'http://sws.geonames.org/2088122',
+          expect(subject.first).to eq("id" => 'http://sws.geonames.org/2088122/',
                                       "label" => "Port Moresby, National Capital, Papua New Guinea")
-          expect(subject.last).to eq("id" => 'http://sws.geonames.org/377039',
+          expect(subject.last).to eq("id" => 'http://sws.geonames.org/377039/',
                                      "label" => "Port Sudan, Red Sea, Sudan")
           expect(subject.size).to eq(10)
         end