Add config for work_file_required, fixes #1715

app/assets/javascripts/sufia/save_work/save_work_control.es6

@@ -104,6 +104,9 @@ export class SaveWorkControl {
 
   // sets the files indicator to complete/incomplete
   validateFiles() {
+    if (!this.uploads.hasFileRequirement) {
+      return true
+    }
     if (!this.isNew || this.uploads.hasFiles) {
       this.requiredFiles.check()
       return true

app/assets/javascripts/sufia/save_work/uploaded_files.es6

@@ -5,6 +5,11 @@ export class UploadedFiles {
     $('#fileupload').bind('fileuploadcompleted', callback)
   }
 
+  get hasFileRequirement() {
+    let fileRequirement = this.form.find('li#required-files')
+    return fileRequirement.size() > 0
+  }
+
   get hasFiles() {
     let fileField = this.form.find('input[name="uploaded_files[]"]')
     return fileField.size() > 0

app/views/curation_concerns/base/_form_progress.html.erb

@@ -8,7 +8,9 @@
         <legend class="legend-save-work">Requirements</legend>
         <ul class="requirements">
           <li class="incomplete" id="required-metadata">Enter required metadata</li>
-          <li class="incomplete" id="required-files">Add files</li>
+          <% if Sufia.config.work_requires_files %>
+            <li class="incomplete" id="required-files">Add files</li>
+          <% end %>
         </ul>
       </fieldset>
     </div>

lib/generators/sufia/templates/config/sufia.rb

@@ -75,6 +75,11 @@
   # The default is true.
   # config.active_deposit_agreement_acceptance = true
 
+  # Should work creation require file upload, or can a work be created first
+  # and a file added at a later time?
+  # The default is true.
+  # config.work_requires_files = true
+
   # Should a button with "Share my work" show on the front page to all users (even those not logged in)?
   # config.always_display_share_button = true
 

lib/sufia/configuration.rb

@@ -63,6 +63,12 @@ def active_deposit_agreement_acceptance
       @active_deposit_agreement_acceptance
     end
 
+    attr_writer :work_requires_files
+    def work_requires_files
+      return true if @work_requires_files.nil?
+      @work_requires_files
+    end
+
     attr_writer :batch_user_key
     def batch_user_key
       @batch_user_key ||= 'batchuser@example.com'

spec/javascripts/save_work_spec.js

@@ -98,7 +98,8 @@ describe("SaveWorkControl", function() {
       beforeEach(function() {
         target = buildTarget(form_id)
         target.uploads = {
-          hasFiles: true
+          hasFiles: true,
+          hasFileRequirement: true
         };
       });
       it("is complete", function() {
@@ -112,7 +113,8 @@ describe("SaveWorkControl", function() {
       beforeEach(function() {
         target = buildTarget(form_id)
         target.uploads = {
-          hasFiles: false
+          hasFiles: false,
+          hasFileRequirement: true
         };
       });
 

spec/javascripts/uploaded_files_spec.js

@@ -0,0 +1,23 @@
+describe("UploadedFiles", function() {
+  var control = require('sufia/save_work/uploaded_files');
+
+  describe("hasFileRequirement", function() {
+    describe("with required file element", function() {
+      it("returns true", function() {
+        var fixture = setFixtures('<form><ul class="requirements"><li class="incomplete" id="required-files">Add files</li></ul></form>');
+        var element = fixture.find('form');
+        target = new control.UploadedFiles(element);
+        expect(target.hasFileRequirement).toBe(true);
+      });
+    });
+
+    describe("without required file element", function() {
+      it("returns false", function() {
+        var fixture = setFixtures('<form><ul class="requirements"><li>Not files</li></ul></form>');
+        var element = fixture.find('form');
+        target = new control.UploadedFiles(element);
+        expect(target.hasFileRequirement).toBe(false);
+      });
+    });
+  });
+});