Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Breaking change in 1.18.4 but only patch part of version updated #2601

Closed
Discordia opened this issue Oct 9, 2020 · 2 comments
Closed

Comments

@Discordia
Copy link

The last version 1.18.4 includes a breaking change: https://projectlombok.org/changelog - but only the patch version was updated. It broke our nightly builds since we have a + on the patch version. Do you not follow https://semver.org/ and can this be expected again?

@Discordia Discordia changed the title [BUG] [BUG] Breaking change in 1.18.4 but only patch part of version updated Oct 9, 2020
@Rawi01
Copy link
Collaborator

Rawi01 commented Oct 15, 2020

One of the maintainers wrote a statement about semver here, I think you can expect it to happen again.

@rspilker
Copy link
Collaborator

There are only two ways to correctly use semver:

  • Keep the major version number at 0. According to semver, this means all versions are experimental and there are no guarantees regarding backwards compatibility.
  • Always increment the major version number. There are no guarantees regarding backwards compatibility.

Even a bugfix is an observable change in behavior that potentially breaks some other person's build. Given the amount of users we have, this has happened for nearly all bugfixes in the past.

We do increment the minor version number if we expect a bigger impact. You could say we do loose semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants