Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.18.14 breaks @Delegate #2610

Closed
lprimak opened this issue Oct 15, 2020 · 2 comments
Closed

1.18.14 breaks @Delegate #2610

lprimak opened this issue Oct 15, 2020 · 2 comments

Comments

@lprimak
Copy link

lprimak commented Oct 15, 2020

Describe the bug
Code with @Delegate is now broken, works in 1.18.12

To Reproduce

git clone https://github.com/flowlogix/flowlogix
edit flowlogix-bom/pom.xml to change lombok version from .12 to .14
mvn package

Expected behavior
expected to compile

Version info (please complete the following information):
mac / maven / Java 8 (latest)

Additional context
Compile error:
The method below is a delegated method, and it is not generated anymore by Lombok

[ERROR] /Users/lprimak/Documents/devel/flowlogix/jakarta-ee/flowlogix-jee/src/main/java/com/flowlogix/jeedao/impl/TypedNativeQueryImpl.java:[30,8] com.flowlogix.jeedao.impl.TypedNativeQueryImpl is not abstract and does not override abstract method <T>unwrap(java.lang.Class<T>) in javax.persistence.Query
@Rawi01
Copy link
Collaborator

Rawi01 commented Oct 15, 2020

You added excludes = TypedNativeQuery.class and TypedNativeQuery implements Query, I think thats why @Delegate does not add the method. The detection of methods in supertypes was improved so it might be possible that lombok now properly find this method and exclude it.

Lombok 1.18.14 should now also detect if the method is already implemented and skip that one. In your case removing the excludes should help (haven't tried it).

@lprimak
Copy link
Author

lprimak commented Oct 15, 2020

That worked
However, since this is a breaking change, I believe two things should happen:

  • some kind of changelog
  • better error message when that happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants