Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dat-gui #38

Closed
dmasad opened this issue Nov 7, 2014 · 2 comments
Closed

Implement dat-gui #38

dmasad opened this issue Nov 7, 2014 · 2 comments
Assignees

Comments

@dmasad
Copy link
Member

dmasad commented Nov 7, 2014

Add dat-gui to the ASCII server.

@dmasad
Copy link
Member Author

dmasad commented Nov 13, 2014

This is basically resolved in the appropriate branch. However, it wasn't as elegant as I hoped, because:

I tried wrapping the entire visualization everything in a 'class' in a separate file, which was very elegant. However, right now, model animation is handled by setInterval, which is controlled at the Window level, and hence doesn't have access to the object's this property. This is a known issue, which is actually called The 'this' issue. I tried implementing the hack that the Mozilla documentation suggests, but it wasn't working for me for some reason.
¯_(ツ)_/¯

The current template code is messier, but since I don't anticipate an urgent need to run multiple models in a single window, we can probably live with the control functions all being global.

@dmasad
Copy link
Member Author

dmasad commented Nov 29, 2014

Yup done.

@dmasad dmasad closed this as completed Nov 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants