Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose variable_count to the user #27

Closed
ProjectMoon opened this issue Oct 22, 2020 · 2 comments
Closed

Do not expose variable_count to the user #27

ProjectMoon opened this issue Oct 22, 2020 · 2 comments

Comments

@ProjectMoon
Copy link
Owner

Variable count is stored as a variable for the user. Do not allow it to be deleted. It also should not show up in lists, or count towards the limit.
@ProjectMoon ProjectMoon changed the title Do not allow deletion of variable count Do not expose variable_count to the user Oct 22, 2020
@ProjectMoon
Copy link
Owner Author

Solution is to add a metadata key space in the variables tree, where we keep track of the variable count with a different prefix.

I suppose we could also put it in an entirely different metadata tree, but maybe that's not so useful.

@ProjectMoon
Copy link
Owner Author

Fixed in 794bf0b.

We need #29 to actually fix the count of existing variables though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ProjectMoon