Add content-ID to REST API v2 entries endpoint #5879
Conversation
| .as(EntriesResponse.class); | ||
| assertThat(entries.getEntries()) | ||
| .hasSize(1) | ||
| .allSatisfy(e -> assertThat(e.getContentId()).isNull()); |
There was a problem hiding this comment.
Do you think a plain JSON string test like testCommitMetaAttributes for the new content ID attribute is worth adding (in addition to this test, or replacing this test)? My thinking is that java code blurs the case of having a null attribute with not having an attribute.
There was a problem hiding this comment.
I think it's okay to leave it out.
|
Hum - something's broken :( |
|
Damn - if |
Ah - not an issue at all - that's only used from the namespace API, which doesn't get the content-ID anyway - so all good :) |
|
Codecov ReportBase: 83.90% // Head: 83.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5879 +/- ##
==========================================
+ Coverage 83.90% 83.92% +0.02%
==========================================
Files 31 31
Lines 1491 1493 +2
Branches 239 240 +1
==========================================
+ Hits 1251 1253 +2
Misses 172 172
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fixes #5878