Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI-Build: Use openapi-generator jar directly #6411

Merged
merged 2 commits into from Mar 27, 2023

Conversation

snazy
Copy link
Member

@snazy snazy commented Mar 27, 2023

This simplifies Gradle dependencies/up-to-date checks, removes the (unnecessary) npm roundtrip and eventually also makes it run a bit quicker.

This simplifies Gradle dependencies/up-to-date checks, removes the
(unnecessary) npm roundtrip and eventually also makes it run a bit
quicker.

Also "silences" the NPM/NodeJS tasks "spam" messages.
@snazy snazy force-pushed the ui-openapi-jar branch 2 times, most recently from 13278c1 to 66142c3 Compare March 27, 2023 13:43
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.71 🎉

Comparison is base (0eaa033) 83.96% compared to head (66142c3) 84.67%.

❗ Current head 66142c3 differs from pull request most recent head 514fcbf. Consider uploading reports for the commit 514fcbf to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6411      +/-   ##
============================================
+ Coverage     83.96%   84.67%   +0.71%     
- Complexity        0      537     +537     
============================================
  Files            31      914     +883     
  Lines          1497    36981   +35484     
  Branches        240     3285    +3045     
============================================
+ Hits           1257    31315   +30058     
- Misses          172     4475    +4303     
- Partials         68     1191    +1123     
Flag Coverage Δ
java 84.72% <ø> (∅)
javascript 82.91% <ø> (∅)
python 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 883 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snazy snazy merged commit e7a79a1 into projectnessie:main Mar 27, 2023
15 checks passed
@snazy snazy deleted the ui-openapi-jar branch March 27, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants