Remove the need to pass Put.expectedContent()
#6438
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6438 +/- ##
============================================
+ Coverage 83.23% 84.54% +1.31%
Complexity 537 537
============================================
Files 909 909
Lines 36033 36033
Branches 3220 3220
============================================
+ Hits 29991 30465 +474
+ Misses 4907 4399 -508
- Partials 1135 1169 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
snazy
changed the title
Put + DeletePut.expectedContent()
snazy
force-pushed
the
clearer-put-delete
branch
from
7199cd5
to
a0e1af9
Compare
snazy
force-pushed
the
clearer-put-delete
branch
from
a0e1af9
to
8423025
Compare
| .toBranch(branch)) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessage("Key 't3' does not exist, but Put-operation has expectedValue"); | ||
| .hasMessage("New value for new must not have a content iD"); |
There was a problem hiding this comment.
nit: the message looks odd to me 🤷
There was a problem hiding this comment.
Why? It's trying to create an IcebergTable with a content-ID, which is not allowed
There was a problem hiding this comment.
Maybe quote the key in the message? This particular message is just hard to read :)
There was a problem hiding this comment.
Also iD starts with a lower case ;)
`expectedContent` was originally introduced for global-state, which has been removed a while ago. The field `expectedContent` is still present and used for REST API v1, but excluded for REST API v2.
snazy
force-pushed
the
clearer-put-delete
branch
from
8423025
to
0843d07
Compare
expectedContentwas originally introduced for global-state, which hasbeen removed a while ago.
The field
expectedContentis still present and used for REST API v1,but excluded for REST API v2.