Do not let Weld register a shutdown hook #6470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shutdown hooks are a nice feature, but registered shutdown hooks can easily lead to out-of-memory errors, especially when used from "re-generated" class loaders or, in situations like the one in our compatibility tests.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6470 +/- ##
============================================
- Coverage 83.96% 83.18% -0.79%
- Complexity 0 537 +537
============================================
Files 31 911 +880
Lines 1497 36031 +34534
Branches 240 3210 +2970
============================================
+ Hits 1257 29972 +28715
- Misses 172 4930 +4758
- Partials 68 1129 +1061
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 878 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dimas-b
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutdown hooks are a nice feature, but registered shutdown hooks can easily lead to out-of-memory errors, especially when used from "re-generated" class loaders or, in situations like the one in our compatibility tests.