Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI-Workflow updates #6481

Merged
merged 1 commit into from Apr 11, 2023
Merged

CI-Workflow updates #6481

merged 1 commit into from Apr 11, 2023

Conversation

snazy
Copy link
Member

@snazy snazy commented Apr 3, 2023

  • Use github.ref for the concurrency group, hoping that previous WF run works with that (see comment in this PR below).
  • The Ci Success step doesn't need to be a matrix job

@snazy
CI-Workflow updates
aaaddea 
* Use `github.ref` for the `concurrency` group, hoping that previous WF
  run works with that (see comment in this PR below).
* The `Ci Success` step doesn't need to be a matrix job
@snazy snazy added pr-docker Smoke test Docker images pr-helm Helm chart testing pr-integrations NesQuEIT (Iceberg, Spark, Flink, Presto) pr-native run native test labels Apr 3, 2023
@snazy
Copy link
Member Author

snazy commented Apr 3, 2023

GitHub concurrency group cancelled the wrong runs - GH did not cancel "older" runs, but the newer ones. This might also be a bug at GitHub though.

image

@snazy snazy marked this pull request as draft April 4, 2023 12:02
@snazy
Copy link
Member Author

snazy commented Apr 4, 2023

Oh my, GH handling of concurrency/cancel-in-progress is ... weird. If GH can submit a job (aka not bound by the max number of concurrent WF jobs), it's (most of the time) correct and cancels older jobs.
However, it seems that either when the concurrent WF job limit is reached, or the WF runs are submitted "too quick" (same timestamp?), GH cancels the wrong WFs/jobs, leaving PRs without checks and lettings the WFs run with the wrong state (PR labels).

Background: Each label addition emits an event, which then triggers a WF run. So if a PR is created and auto-labeler decides to add 4 labels, the PR workflow(s) get triggered 5 times - and only the latest should run. This is most often the case, but sadly not always.

Moving this PR back to "draft" to come up with a properly working solution.

@snazy snazy mentioned this pull request Apr 5, 2023
Merged
@snazy snazy marked this pull request as ready for review April 8, 2023 16:58
@snazy snazy merged commit afed1b2 into projectnessie:main Apr 11, 2023
39 of 57 checks passed
@snazy snazy deleted the ci-wf-updates branch April 11, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimas-b dimas-b dimas-b approved these changes

Assignees
No one assigned
Labels
pr-docker Smoke test Docker images pr-helm Helm chart testing pr-integrations NesQuEIT (Iceberg, Spark, Flink, Presto) pr-native run native test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snazy @dimas-b