Gradle: eliminate some more doFirst/doLast script references
#6516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
added
pr-integrations
snazy
force-pushed
the
gradle-script-refs
branch
6 times, most recently
from
fcf423a
to
aac7adc
Compare
snazy
force-pushed
the
gradle-script-refs
branch
from
aac7adc
to
c22e35a
Compare
snazy
commented
Apr 12, 2023
| @@ -15,6 +15,10 @@ | |||
| */ | |||
| grammar NessieSqlExtensions; | |||
|
|
|||
| @header { | |||
| // PACKAGE_PLACEHOLDER | |||
There was a problem hiding this comment.
This makes the ReplaceInFiles idempotent
| @@ -78,9 +78,9 @@ dependencies { | |||
|
|
|||
| tasks.withType(Test::class.java).configureEach { | |||
| systemProperty("aws.region", "us-east-1") | |||
| val tmpdir = project.buildDir.resolve("tmpdir") | |||
There was a problem hiding this comment.
Moves the reference to project out of task execution, which is mandatory to enable Gradle's configuration cache.
| @@ -81,12 +81,9 @@ class NessieTestingPlugin : Plugin<Project> { | |||
| } | |||
| if (plugins.hasPlugin("io.quarkus")) { | |||
| // This directory somehow disappears... Maybe some weird Quarkus code. | |||
| tasks.named("quarkusGenerateCodeTests") { | |||
There was a problem hiding this comment.
Such changes elimniate the use of script references, which do not work with Gradle's configuration cache (not serializable)
dimas-b
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.