Support @NessieServerProperty annotations in nested tests
#6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
reviewed
Apr 11, 2023
This seemed to be the easiest and most relevant class to validate the fix. I know it looks odd with duplicate test methods in the main class and in the nested class, but it seems to be the only way to validate that config changes are effective. Otherwise, we'd have to expose internal properties to tests, I guess, which would have a larger impact and is probably not really necessary for now. |
|
Hmmm. But then let's at least add a comment to those. |
dimas-b
force-pushed
the
fix-server-config-in-nested-compat-tests
branch
from
74356a8
to
3ae947f
Compare
* `@NessieServerProperty` annotations are processed on all test classes starting from the root context. * Properties in inner / nested contexts take precedence over properties in outer contexts.
dimas-b
force-pushed
the
fix-server-config-in-nested-compat-tests
branch
from
3ae947f
to
0dfdc0b
Compare
snazy
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NessieServerPropertyannotations are processed on all test classes starting from the root context.Properties in inner / nested contexts take precedence over properties in outer contexts.