Expose Nessie repository information (preparation) #6635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
reviewed
Apr 20, 2023
api/model/src/main/java/org/projectnessie/model/RepositoryInformation.java
Outdated
Show resolved
Hide resolved
servers/jax-rs-tests/src/main/java/org/projectnessie/jaxrs/tests/BaseTestNessieApi.java
Outdated
Show resolved
Hide resolved
...rsist/store/src/main/java/org/projectnessie/versioned/persist/store/PersistVersionStore.java
Outdated
Show resolved
Hide resolved
versioned/spi/src/main/java/org/projectnessie/versioned/TracingVersionStore.java
Outdated
Show resolved
Hide resolved
api/model/src/main/java/org/projectnessie/model/RepositoryInformation.java
Outdated
Show resolved
Hide resolved
api/model/src/main/java/org/projectnessie/api/v2/http/HttpConfigApi.java
Outdated
Show resolved
Hide resolved
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Apr 20, 2023
Builds on the API changes from projectnessie#6635 Fixes projectnessie#4993 Fixes projectnessie#5810
Enhances the REST endpoint `v2/config` with repository specific information: * repository creation timestamp (new storage model only) * oldest possible commit timestamp (new storage model only) * no-ancestor-hash value * default branch name (currently hard-wired to the configuration value) Prepares the API changes for projectnessie#4993 and projectnessie#5810. Since this changes the existing model for v2-beta, the added fields will be populated in a follow-up-PR.
snazy
changed the title
|
I've changed this PR to not expose a new REST endpoint but extend the existing This PR adds new attributes to |
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Apr 20, 2023
Builds on the API changes from projectnessie#6635 Fixes projectnessie#4993 Fixes projectnessie#5810
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Apr 20, 2023
Builds on the API changes from projectnessie#6635 Fixes projectnessie#4993 Fixes projectnessie#5810
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Apr 20, 2023
Builds on the API changes from projectnessie#6635 Fixes projectnessie#4993 Fixes projectnessie#5810
dimas-b
approved these changes
Apr 20, 2023
| public abstract String getNoAncestorHash(); | ||
|
|
||
| /** | ||
| * Timestamp when the repository has been created. |
| private final ServerConfig config; | ||
|
|
||
| public ConfigApiImpl(ServerConfig config) { | ||
| public ConfigApiImpl(ServerConfig config, VersionStore store) { | ||
| this.store = store; |
There was a problem hiding this comment.
nit: This can pprobably be in #6640
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Apr 21, 2023
Builds on the API changes from projectnessie#6635 Fixes projectnessie#4993 Fixes projectnessie#5810
snazy
added a commit
to snazy/nessie
that referenced
this pull request
May 12, 2023
Builds on the API changes from projectnessie#6635 Fixes projectnessie#4993 Fixes projectnessie#5810
snazy
added a commit
to snazy/nessie
that referenced
this pull request
May 18, 2023
Builds on the API changes from projectnessie#6635 Fixes projectnessie#4993 Fixes projectnessie#5810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the REST endpoint
v2/configwith repository specific information:Prepares the API changes for #4993 and #5810.
Since this changes the existing model for v2-beta, the added fields will be populated in a follow-up-PR.