bugfix: namespaceDepth filter loses entry content #6648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implicit namespaces are somewhat deprecated and thus also the namespaceDepth filter however as long as the filter exists, it should not lose already retrieved information about the content of real entries
XN137
commented
Apr 21, 2023
| soft.assertThat(entries) | ||
| .hasSize(2) | ||
| .map(e -> immutableEntry(e.getName(), e.getType())) | ||
| .containsExactlyInAnyOrder( | ||
| immutableEntry(ContentKey.of("a", "b", "c", "secondTable"), Content.Type.ICEBERG_TABLE), | ||
| immutableEntry(ContentKey.of("a", "b", "c", "firstTable"), Content.Type.ICEBERG_TABLE)); | ||
|
|
||
| // namespaceDepth filter always returns contentId of real entries | ||
| entries = entries(reference.getName(), reference.getHash(), 4, filterThatFindsTwoTables, false); |
There was a problem hiding this comment.
before the fix:
java.lang.AssertionError:
Expecting all elements of:
[Entry{type=ICEBERG_TABLE, name=a.b.c.firstTable, contentId=null, content=null},
Entry{type=ICEBERG_TABLE, name=a.b.c.secondTable, contentId=null, content=null}]
to satisfy given requirements, but these elements did not:
see how both contentId and content were always null
XN137
commented
Apr 21, 2023
| EntriesResponse.Entry.entry(key.getKey(), key.getType(), key.getContentId()); | ||
| c != null | ||
| ? EntriesResponse.Entry.entry(key.getKey(), key.getType(), c) | ||
| : EntriesResponse.Entry.entry(key.getKey(), key.getType(), key.getContentId()); |
There was a problem hiding this comment.
note this is the same logic as in the else branch of the line 768 if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implicit namespaces are somewhat deprecated and thus also the namespaceDepth filter
however as long as the filter exists, it should not lose already retrieved information about the content of real entries