Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extraEnv to helm chart #6698

Merged
merged 6 commits into from May 4, 2023
Merged

Add extraEnv to helm chart #6698

merged 6 commits into from May 4, 2023

Conversation

c-thiel
Copy link
Contributor

@c-thiel c-thiel commented Apr 27, 2023

Fixes #6670

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

adutra
adutra requested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@adutra adutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, I like how it's flexible and applies to other possible use cases as well.

helm/nessie/templates/deployment.yaml Outdated Show resolved Hide resolved
adutra
adutra reviewed Apr 27, 2023
View reviewed changes
helm/nessie/values.yaml Outdated Show resolved Hide resolved
@snazy
Copy link
Member

snazy commented Apr 28, 2023

@c-thiel can you sign the CLA?

@c-thiel
Copy link
Contributor Author

c-thiel commented Apr 29, 2023 •
edited

I signed the CLA for my Github Account. I did some doc changes unfortunately on my iPad with a wrongly configured author.
I added the E-Mail after that to my github and verified it, but it doesn't show up correctly in this PR.
Is this still OK?
Otherwise I would need to create a new PR.

@adutra
Copy link
Contributor

adutra commented Apr 30, 2023

Maybe you could squash your commits and force-push the squashed commit with your verified GitHub account?

@c-thiel
Copy link
Contributor Author

c-thiel commented May 3, 2023

Ok, I did some rebase. You need to check again though.

@snazy snazy requested a review from adutra May 3, 2023 18:21
@adutra adutra merged commit 3700b4b into projectnessie:main May 4, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adutra adutra adutra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Chart: Add option to get MongoDB Connection String from Secret
4 participants
@c-thiel @CLAassistant @snazy @adutra