New storage: allow deletion of multiple repositories #6758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
approved these changes
May 5, 2023
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(ints = {1, 3, 10}) |
There was a problem hiding this comment.
Shouldn't we go above MAX_CONCURRENT_DELETES?
There was a problem hiding this comment.
oops - saw it too late - #6768
snazy
added a commit
to snazy/nessie
that referenced
this pull request
May 6, 2023
snazy
added a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only moves the logic from the
Persist.erase()implementations to theirBackend.eraseRepositories(Set)counterparts and makes the implementations delete multiple repos in one shot. No other changes, just moving some already existing code around.