Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ObjId.objIdFromByteBuffer() #6845

Merged
merged 2 commits into from May 17, 2023
Merged

Add ObjId.objIdFromByteBuffer() #6845

merged 2 commits into from May 17, 2023

Conversation

snazy
Copy link
Member

@snazy snazy commented May 17, 2023

No description provided.

dimas-b
dimas-b reviewed May 17, 2023
View reviewed changes
Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, just minor javadoc comments.

...d/storage/common/src/main/java/org/projectnessie/versioned/storage/common/persist/ObjId.java Outdated
@@ -110,20 +118,43 @@ public static ObjId objIdFromBytes(ByteString bytes) {
}
}

/**
* Creates an {@link ObjId} from its bytes representation, assuming that all remaining data in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the remaining piece is a bit misleading... the byte array is treated whole, is it not? There is no moving pointer 🤔

...d/storage/common/src/main/java/org/projectnessie/versioned/storage/common/persist/ObjId.java Outdated
@@ -98,6 +98,14 @@ public static ObjId objIdFromString(@Nonnull @jakarta.annotation.Nonnull String
}
}

/**
* Creates an {@link ObjId} from its bytes representation, assuming that all remaining data in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the remaining piece is a bit misleading... ByteString does not have a "pointer" (unlike ByteBuffer), does it?

@snazy snazy merged commit edd1f6c into projectnessie:main May 17, 2023
24 checks passed
@snazy snazy deleted the objid-from-bb branch May 17, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimas-b dimas-b dimas-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snazy @dimas-b