Events notification system for Nessie - Quarkus #6870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
commented
May 22, 2023
| @Produces | ||
| @Singleton | ||
| public MeterFilter configureGlobalTags() { | ||
| return MeterFilter.commonTags(Tags.of(APPLICATION_TAG_NAME, APPLICATION_TAG_VALUE)); |
There was a problem hiding this comment.
This is a global bean and as such, interferes with other usages of MeterRegistry throughout the application. Which is why the returned MeterFilter contains exactly the same tags used in MetricsVersionStore – this way we don't alter its behavior.
We might want to improve this later on and have a global strategy for metrics tags in Nessie.
adutra
commented
May 22, 2023
| } | ||
|
|
||
| @Test | ||
| void testCommitWithTracing() { |
There was a problem hiding this comment.
To help understand the spans used in events, here is a screenshot of Jaeger UI for the spans produced by this test:
adutra
force-pushed
the
events-quarkus
branch
8 times, most recently
from
3cbb7ad
to
4891186
Compare
snazy
reviewed
May 25, 2023
events/service/src/main/java/org/projectnessie/events/service/util/SubscriberUtil.java
Outdated
Show resolved
Hide resolved
events/service/src/main/java/org/projectnessie/events/service/EventSubscribers.java
Outdated
Show resolved
Hide resolved
events/spi/src/main/java/org/projectnessie/events/spi/EventSubscription.java
Show resolved
Hide resolved
...arkus/src/main/java/org/projectnessie/events/quarkus/config/VersionStoreConfigConstants.java
Outdated
Show resolved
Hide resolved
adutra
force-pushed
the
events-quarkus
branch
2 times, most recently
from
aafeed5
to
db893a5
Compare
|
Heads up: had to rebase because of conflicts. |
snazy
reviewed
May 30, 2023
.../src/main/java/org/projectnessie/events/quarkus/collector/QuarkusResultCollectorFactory.java
Outdated
Show resolved
Hide resolved
...s/quarkus/src/main/java/org/projectnessie/events/quarkus/delivery/StandardEventDelivery.java
Show resolved
Hide resolved
events/quarkus/src/main/java/org/projectnessie/events/quarkus/config/QuarkusEventConfig.java
Show resolved
Hide resolved
snazy
reviewed
May 31, 2023
.../quarkus/src/main/java/org/projectnessie/events/quarkus/delivery/RetriableEventDelivery.java
Outdated
Show resolved
Hide resolved
snazy
reviewed
May 31, 2023
...quarkus/src/main/java/org/projectnessie/events/quarkus/delivery/DelegatingEventDelivery.java
Outdated
Show resolved
Hide resolved
...s/quarkus/src/main/java/org/projectnessie/events/quarkus/delivery/StandardEventDelivery.java
Outdated
Show resolved
Hide resolved
...s/quarkus/src/main/java/org/projectnessie/events/quarkus/delivery/StandardEventDelivery.java
Show resolved
Hide resolved
This commit introduces a new module, nessie-events-quarkus.
To improve isolation and facilitate testing, this new module
is completely independent of other Quarkus modules; it
contains:
1. Quarkus-specific implementations of nessie-events-service
classes;
2. Asynchronous delivery based on Vert.x, both non-blocking
and blocking;
3. Delivery with optional logging, tracing and metrics.
Changes outside this module are minimal:
1. A few changes were introduced in nessie-events-api,
nessie-events-spi and nessie-events-service.
2. nessie-quarkus-common:
1. ConfigurableVersionStoreFactory changed to detect when
events are enabled;
2. New RepositoryIdProvider.
3. nessie-quarkus (server):
1. Compile-time dependency on nessie-events-quarkus;
2. Smoke tests.
snazy
approved these changes
Jun 1, 2023
|
Let's merge manually to have a "nicer" commit message. |
I changed the commit message when I enabled auto-merge :-) – but OK, let's wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new module,
nessie-events-quarkus. To improve isolation and facilitate testing, this new module is completely independent of other Quarkus modules; it contains:nessie-events-serviceclasses;nessie.version.store.XYZ.enableoptions.Changes outside this module are minimal:
nessie-events-api,nessie-events-spiandnessie-events-service.nessie-quarkus-common:VersionStoreConfighas a newisEventsEnabled()method mapped to thenessie.version.store.events.enableproperty, true by default;ConfigurableVersionStoreFactorychanged to detect when events are enabled;RepositoryIdProvider: creates a bean holding the repository id.nessie-quarkus(server):nessie-events-quarkus;