Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gc-base, gc-iceberg classes Java 8 compatible #7174

Merged
merged 1 commit into from Jul 3, 2023

Conversation

ajantha-bhat
Copy link
Contributor

@ajantha-bhat ajantha-bhat commented Jul 1, 2023

GC modules can be used by engines to build its own distributed GC logic. Hence, it has to be java8 compatible.

@ajantha-bhat ajantha-bhat marked this pull request as draft July 1, 2023 15:00
@ajantha-bhat ajantha-bhat changed the title Make gc-base, gc-iceberg and its dependency classes java8 compatible Make gc-base, gc-iceberg and its dependency classes Java 8 compatible Jul 1, 2023
@ajantha-bhat ajantha-bhat marked this pull request as ready for review July 1, 2023 15:53
@ajantha-bhat ajantha-bhat requested review from snazy and XN137 July 3, 2023 06:17
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR this is way too much, doing way more than necessary

@ajantha-bhat
Copy link
Contributor Author

ajantha-bhat commented Jul 3, 2023

TL;DR this is way too much, doing way more than necessary

Goal was to make gc-base and gc-iceberg compatible with java 8.
So, I changed nessie-conventions-iceberg to use java 8 and then started fixing its dependencies compatibility.

May be you meant introduce a new profile nessie-conventions-iceberg8 and use for only gc-base and gc-iceberg and its dependencies. I will give it a try.

@ajantha-bhat ajantha-bhat changed the title Make gc-base, gc-iceberg and its dependency classes Java 8 compatible Make gc-base, gc-iceberg classes Java 8 compatible Jul 3, 2023
@ajantha-bhat
Copy link
Contributor Author

TL;DR this is way too much, doing way more than necessary

Updated.

@snazy snazy merged commit c1a1932 into projectnessie:main Jul 3, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants