Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CHANGELOG.md, include in release information #7243

Merged
merged 1 commit into from Jul 18, 2023

Conversation

snazy
Copy link
Member

@snazy snazy commented Jul 14, 2023

The information about a specific Nessie release is pretty rudimentary, consists only of a list of commits. Interesting, important and relevant information, for example about upgrade notes, release highlights, potentially breaking changes, is missing in the release notes.

This change introduces the CHANGELOG.md file. Relevant information is to be added to an appropriate section for Unreleased. The list of sections is not fixed and can be changed and extended, depending on the impact of an individual change/PR.

The Nessie release workflows leverage Jetbrains' Gradle Changelog Plugin to promote Unreleased to a release in CHANGELOG.md and to extract the changelog for the current release, which is then added to site/docs/try/releases.md and the Github release notes. The changelog-plugin is "clever enough" to purge empty sections for a release.

This is the command to extract information about the latest release

./gradlew --quiet --console=plain getChangelog --no-header --no-links

Using ./gradlew getChangelog --unreleased shows information about the not-yet-released code.

@snazy snazy marked this pull request as ready for review July 17, 2023 15:31
The information about a specific Nessie release is pretty rudimentary, consists only of a list of commits. Interesting, important and relevant information, for example about upgrade notes, release highlights, potentially breaking changes, is missing in the release notes.

This change introduces the `CHANGELOG.md` file. Relevant information is to be added to an appropriate section for `Unreleased`. The list of sections is not fixed and can be changed and extended, depending on the impact of an individual change/PR.

The Nessie release workflows leverage Jetbrains' [_Gradle Changelog Plugin_](https://github.com/JetBrains/gradle-changelog-plugin) to promote `Unreleased` to a release in `CHANGELOG.md` and to extract the changelog for the current release, which is then added to `site/docs/try/releases.md` and the Github release notes. The changelog-plugin is "clever enough" to purge empty sections for a release.

This is the command to extract information about the latest release
```bash
./gradlew --quiet --console=plain getChangelog --no-header --no-links
```

Using `./gradlew getChangelog --unreleased` shows information about the not-yet-released code.
Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments (questions)

- Tests: Make `ITCassandraBackendFactory` less flaky (#7186)
- IntelliJ: Exclude some more directories from indexing (#7181)

[Unreleased]: https://github.com/projectnessie/nessie/commits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this line? Should it perhaps be in the Unreleased > Commits section above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required (and maintained) by the changelog-pluigin.
BTW: That's a link-definition

@snazy snazy merged commit 48b6e30 into projectnessie:main Jul 18, 2023
17 checks passed
@snazy snazy deleted the changelog-plugin branch July 18, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants