Combined Nessie server+client for testing #7527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
combined-nessie-client-server
branch
from
6fc1f75
to
7cf6a0c
Compare
snazy
commented
Sep 20, 2023
|
|
||
| @Test | ||
| @NessieApiVersions(versions = {NessieApiVersion.V2}) | ||
| public void testErrorsV2() throws Exception { |
There was a problem hiding this comment.
This test exercises the "exception mapping" in the added client impl
Introduce a new `:nessie-combined-cs` module (under `testing/`) providing a Nessie-API (v2) client that directly calls the service implementations, using the v2 REST endpoint implementations. This eliminates the need for a Jersey/Weld based Nessie endpoint for testing purposes. The implementation in this PR (currently) provides only a new-storage model in-memory backend.
snazy
force-pushed
the
combined-nessie-client-server
branch
from
7cf6a0c
to
78df51d
Compare
dimas-b
approved these changes
Sep 23, 2023
|
|
||
| // Optimistic cast... | ||
| @SuppressWarnings("unchecked") | ||
| API r = (API) new CombinedClientImpl(configResource, treeResource); |
There was a problem hiding this comment.
nit: apiContract.cast(..) instead of @SuppressWarnings
Comment on lines
+178
to
+179
| createClientBuilder("Combined", null) | ||
| .asInstanceOf(CombinedClientBuilder.class) |
There was a problem hiding this comment.
Could we somehow "combine" these calls... something like createClientBuilder(Class<T> builder)... the name looks redundant in this context (separate PR, of course, if you agree).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
:nessie-combined-csmodule (undertesting/) providing a Nessie-API (v2) client that directly calls the service implementations, using the v2 REST endpoint implementations. This eliminates the need for a Jersey/Weld based Nessie endpoint for testing purposes. The implementation in this PR (currently) provides only a new-storage model in-memory backend.