Ensure that content IDs are unique in a Nessie repository #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
ensure-unique-ids
branch
2 times, most recently
from
0ab4be2
to
2c94b17
Compare
snazy
force-pushed
the
ensure-unique-ids
branch
from
2c94b17
to
79c3592
Compare
Nessie content IDs are random IDs, but we do not guarantee that those are actually really unique. This change adds a new object type to ensure that a generated ID is unique by leveraging existing functionality of the `Persist` framework that already provides "`INSERT IF NOT EXIST`" guarantees. New content IDs from this change on are now verified. This change does not include functionality to automatically add already existing content-IDs. IMHO it is probably okay for now given the practically non-existing probability of content-ID conflicts.
snazy
force-pushed
the
ensure-unique-ids
branch
from
79c3592
to
c61ed2f
Compare
adutra
reviewed
Dec 4, 2023
| @@ -122,4 +123,10 @@ static ObjId stringDataHash( | |||
| hasher.putBytes(text.asReadOnlyByteBuffer()); | |||
| return hashAsObjId(hasher); | |||
| } | |||
|
|
|||
| static ObjId uniqueIdHash(String space, String value) { | |||
There was a problem hiding this comment.
One general remark: wouldn't it be simpler to model the value as an opaque byte array? It seems we could save some conversions to and from string in the common case where the value is an UUID.
| import org.projectnessie.versioned.storage.common.persist.Persist; | ||
|
|
||
| /** | ||
| * Describes the <em>internal</em> state of a reference when it has been created, managed by {@link |
There was a problem hiding this comment.
The javadoc seems to refer to RefObj.
adutra
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nessie content IDs are random IDs, but we do not guarantee that those are actually really unique.
This change adds a new object type to ensure that a generated ID is unique by leveraging existing functionality of the
Persistframework that already provides "INSERT IF NOT EXIST" guarantees.New content IDs from this change on are now verified. This change does not include functionality to automatically add already existing content-IDs. IMHO it is probably okay for now given the practically non-existing probability of content-ID conflicts.