Allow per-request base URIs in HttpClient #7922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
force-pushed
the
base-uri-rework
branch
from
9d7f429
to
be10518
Compare
dimas-b
reviewed
Jan 8, 2024
| protected HttpRequest(HttpRuntimeConfig config, URI baseUri) { | ||
| requireNonNull(baseUri, "Base URI cannot be null"); | ||
| checkArgument( | ||
| "http".equals(baseUri.getScheme()) || "https".equals(baseUri.getScheme()), |
There was a problem hiding this comment.
Maybe equalsIgnoreCase? Per rfc3986 implementations should accept either case.
snazy
reviewed
Jan 8, 2024
| static Builder builder() { | ||
| return new HttpClientBuilderImpl(); | ||
| } | ||
|
|
||
| URI getBaseUri(); |
| @@ -31,16 +31,18 @@ runs: | |||
| - name: Gradle / Init | |||
| uses: gradle/gradle-build-action@v2 | |||
| with: | |||
| cache-read-only: ${{ inputs.cache-read-only }} | |||
| # cache-read-only: ${{ inputs.cache-read-only }} | |||
There was a problem hiding this comment.
Trying to fix gradle build cache issues.
| @@ -31,7 +36,14 @@ public abstract class HttpRequest | |||
| protected String accept = "application/json; charset=utf-8"; | |||
|
|
|||
| protected HttpRequest(HttpRuntimeConfig config) { | |||
There was a problem hiding this comment.
I think we can get rid of the single-arg constructor and only use the new one below. WDYT?
|
Authentication is another component that could benefit from a per-request override mechanism – I can look into that in another PR. |
dimas-b
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.