Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix free-disk-space action #7937

Merged
merged 1 commit into from Jan 10, 2024
Merged

Conversation

XN137
Copy link
Contributor

@XN137 XN137 commented Jan 10, 2024

the buildpack-deps images have been removed from the runners: actions/runner-images#9093

so we no longer need to clear them up
(the command was failing any workflow that uses the action)

Error response from daemon: No such image: buildpack-deps:buster
Error response from daemon: No such image: buildpack-deps:bullseye

the buildpack-deps images have been removed from the runners:
actions/runner-images#9093

so we no longer need to clear them up
(the command was failing any workflow that uses the action)
@adutra
Copy link
Contributor

adutra commented Jan 10, 2024

We still should remove all existing docker images. I suggest instead:

    - name: Remove unused Docker images
      shell: bash
      # See https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#cached-docker-images
      run: |
        docker image rm node:16 || true
        docker image rm node:16-alpine || true
        docker image rm node:18 || true
        docker image rm node:18-alpine || true
        docker image rm buildpack-deps:buster || true
        docker image rm buildpack-deps:bullseye || true
        docker image rm moby/buildkit:latest || true
        docker image rm alpine:3.16 || true
        docker image rm alpine:3.17 || true
        docker image rm alpine:3.18 || true
        docker image rm debian:10 || true
        docker image rm debian:11 || true
        docker image rm ubuntu:22.04 || true
        docker image rm ubuntu:20.04 || true

wdyt?

@adutra
Copy link
Contributor

adutra commented Jan 10, 2024

In hindsight, we might want instead to detect future changes to the runner images, so maybe your change is better.

@dimas-b
Copy link
Member

dimas-b commented Jan 10, 2024

|| true

I'd prefer to fail on missing (obsolete) images so that we can keep our scripts lean.

@XN137 XN137 merged commit 4fbb346 into projectnessie:main Jan 10, 2024
16 of 17 checks passed
@XN137 XN137 deleted the fix-free-disk-space branch January 10, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants