Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Java 21 in published Docker images #7973

Merged
merged 1 commit into from Jan 23, 2024
Merged

Use Java 21 in published Docker images #7973

merged 1 commit into from Jan 23, 2024

Conversation

snazy
Copy link
Member

@snazy snazy commented Jan 23, 2024

No description provided.

@snazy
Copy link
Member Author

snazy commented Jan 23, 2024

Review notes: To build/run the image locally:

  1. ./gradlew :nessie-quarkus:quarkusBuild
  2. cd servers/quarkus-server
  3. podman build -t local-nessie -f ../../tools/dockerbuild/docker/Dockerfile-jvm .
  4. podman run -ti --rm -p 19120:19120 local-nessie

@snazy
Copy link
Member Author

snazy commented Jan 23, 2024

podman run -ti --rm -p 19120:19120 --env NESSIE_VERSION_STORE_TYPE=JDBC --env QUARKUS_DATASOURCE_JDBC_URL="jdbc:postgresql://host.com:5432/db" local-nessie works as expected. Similar for JAVA_OPTS

adutra
adutra approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@adutra adutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested JAVA_OPTS_APPEND, JAVA_TOOL_OPTIONS, JAVA_DEBUG and JAVA_MAX_MEM_RATIO env vars, all worked.

@snazy snazy merged commit 4458d8e into projectnessie:main Jan 23, 2024
17 checks passed
@snazy snazy deleted the docker-img-java-21 branch January 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adutra adutra adutra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snazy @adutra