Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VersionStore panels of the Grafana dashboard #8033

Merged
merged 3 commits into from Feb 12, 2024

Conversation

tiwalter
Copy link
Contributor

@tiwalter tiwalter commented Feb 8, 2024

The following fixes were made:

  • Adjust the query for the changed labels of the nessie_versionstore_request_seconds_bucket metric
  • Sync the panels with the current code base (VersionStore methods)
  • Remove the "DB tryloop" panels

Fixes #8032

* Fix the changed labels of the nessie_versionstore_request_seconds_bucket metric
* Remove the "DB tryloop" panels

Signed-off-by: Timo Walter <twalter@walter-se.com>
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall!

I also see JVM stats:
image

One version store method however seems misspelled (added comments).

grafana/nessie.json Outdated Show resolved Hide resolved
grafana/nessie.json Outdated Show resolved Hide resolved
Signed-off-by: Timo Walter <twalter@walter-se.com>
@tiwalter
Copy link
Contributor Author

tiwalter commented Feb 9, 2024

Your remarks have been fixed.
How do we deal with the missing data in the "JVM Process Memory" panel (upper right panel in your screenshot)?

@snazy
Copy link
Member

snazy commented Feb 10, 2024

How do we deal with the missing data in the "JVM Process Memory" panel (upper right panel in your screenshot)?

Hm - good question. I couldn't find a metric for those either. Looks like the ones used in the dashboard no longer exist, and similar ones don't yield any data. I'd be okay to remove the panel, since it has no data and there seems to be no replacement at the moment.

Signed-off-by: Timo Walter <twalter@walter-se.com>
@tiwalter
Copy link
Contributor Author

All right, the panel has been removed.

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the PR, @tiwalter

@snazy snazy merged commit e57e077 into projectnessie:main Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana Dashboard: Some Panels show no data
2 participants