Make Authorizer pluggable
#8090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
previously approved these changes
Feb 20, 2024
| } | ||
|
|
||
| public void eagerAuthorizerInitialization( | ||
| @Observes StartupEvent event, @SuppressWarnings("unused") Authorizer authorizer) { |
There was a problem hiding this comment.
nit: do we actually need the Authorizer parameter? This being an instance method requires QuarkusAuthorizer to be created anyway, right?
There was a problem hiding this comment.
That's exactly the intent here
There was a problem hiding this comment.
It shall initialize it to run into possible config issues early
There was a problem hiding this comment.
That initialization will happen in the QuarkusAuthorizer constructor anyway. The Authorizer reference here will probably cause a CDI resolution error if there are more than one instance available.
There was a problem hiding this comment.
Shouldn't the class be annotated with @Startup instead?
https://quarkus.io/version/main/guides/lifecycle#startup_annotation
servers/quarkus-auth/src/main/java/org/projectnessie/server/authz/QuarkusAuthorizer.java
Outdated
Show resolved
Hide resolved
snazy
force-pushed
the
authz-pluggable
branch
from
2febac8
to
3b73758
Compare
snazy
force-pushed
the
authz-pluggable
branch
from
3b73758
to
24cd144
Compare
dimas-b
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.