JDBC backend: infer catalog and schema if not specified #8131
Conversation
| @Override | ||
| String catalog(); | ||
| Optional<String> catalog(); |
There was a problem hiding this comment.
I believe defaulting to the empty string is wrong. According to the javadocs of java.sql.DatabaseMetaData#getTables:
catalog – a catalog name; must match the catalog name as it is stored in the database; "" retrieves those without a catalog; null means that the catalog name should not be used to narrow the search
So, using the empty string means that we are going to look for tables that do not belong to any catalog, which seems wrong. Same for schema.
Still according to the javadocs, it's imo better to pass null if the catalog is not known, the risk being that a table in a different catalog could exist with the same name as a Nessie table. But in this case, the schema check would fail anyways.
There was a problem hiding this comment.
Update: the PG driver does not seem to comply with the javadocs: looking at the implementation of getTables, catalog is not used at all, and schema is ignored when it's null or empty.
So the previous code was probably correct for PG, but maybe not correct for other drivers.
No description provided.