Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image tool: implement local image builds #8141

Merged
merged 2 commits into from Feb 29, 2024

Conversation

snazy
Copy link
Member

@snazy snazy commented Feb 29, 2024

No description provided.

dimas-b
dimas-b previously approved these changes Feb 29, 2024
@snazy snazy merged commit 560a288 into projectnessie:main Feb 29, 2024
16 checks passed
@snazy snazy deleted the docker-build-local branch February 29, 2024 14:23
--tag "${IMAGE_NAME}:${IMAGE_TAG_BASE}" \
--tag "${IMAGE_NAME}:${IMAGE_TAG_BASE}-java" \
"${BASE_DIR}/${PROJECT_DIR}" \
--push \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a full review yet, but usually when I need to build a local image for use in minikube, I don't bother pushing to insecure registries.

Instead I remove this --push option and execute eval $(minikube docker-env) prior to building the image. This makes the build happen inside minikube, and the image is immediately available in the minikube node.

Have you tried this approach? Is it worth providing support for it as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difficulties begin when you use podman :(

Loads of issues with podman in minikube - that was the only approach that worked for me. (Yes, they document that you can use podman-remote and let that talk to minikube - but no - a huge API version mismatch... - just to name one annoyance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants