OAuth2Client: improve sleep/close detection #8337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
approved these changes
Apr 16, 2024
| @@ -158,6 +158,9 @@ public void close() { | |||
| } | |||
|
|
|||
| private void wakeUp(Instant now) { | |||
| if (closing.get()) { | |||
| return; | |||
There was a problem hiding this comment.
nit: maybe log a debug message in this case?
There was a problem hiding this comment.
Let me merge this as is and I'll add the debug message in #8338.
api/client/src/main/java/org/projectnessie/client/auth/oauth2/OAuth2Client.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements on the sleep/close detection mechanisms:
lastAccesscomputation tostart(), in case the client is instantiated long before being used for the first time;lastAccesswheneverfetchNewTokens()require user interaction (authorization and device code flows): prevents incorrect switch to sleep mode;wakeUp(): no need to wake up; can happen if the client was sleeping, then is closed, thenauthenticate()is called.maybeScheduleTokensRenewal(): no need to check and switch to sleep; avoids the case where the client is closed after some inactivity, thenmaybeScheduleTokensRenewalis called and incorrectly puts the client to sleep.log()simplify the check if log is needed: the token future can only be cancelled iifclosingis true.