Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECANCELED error frequently logged to console.error when calling channel.stop #3

Closed
bbrowning opened this issue Jun 29, 2015 · 3 comments

Comments

@bbrowning
Copy link
Member

I quite often see multiple instances of the below error logged when calling channel.stop

{ [Error: send ECANCELED] code: 'ECANCELED', errno: 'ECANCELED', syscall: 'send' }

It's coming from

console.error(err);
, which may be unnecessary since we also call deferred.reject with the error.

@lance
Copy link
Member

lance commented Jun 29, 2015

@bbrowning I think you are probably right - may really be that we don't need console.error here, since we inform the caller with deferred.reject - informing the user via console or whatever is probably more the client code's responsiblity

@lance
Copy link
Member

lance commented Jun 29, 2015

Addressed in 584747b

@lance lance closed this as completed Jun 29, 2015
@bbrowning
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants