Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: LimitedCapabilityEngine #55

Closed
Strilanc opened this issue Apr 18, 2017 · 3 comments
Closed

Suggestion: LimitedCapabilityEngine #55

Strilanc opened this issue Apr 18, 2017 · 3 comments

Comments

@Strilanc
Copy link
Contributor

For testing decompositions, it's often useful to prevent AutoReplacer from passing along complicated gates. This functionality could go into DummyEngine, but separating it out keeps DummyEngine simple.

See #54 for the basic idea.
@thomashaener
Copy link
Contributor

Sure, why not. While it is basically an InstructionFilter, it's nice to have for testing.

@Strilanc
Copy link
Contributor Author

Oh, you do have an existing engine for this. In that case it would make more sense to merge behaviors into it rather than make a separate one.

@thomashaener
Copy link
Contributor

I think having a separate one makes sense, but the new one can, e.g., derive from InstructionFilter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Strilanc @thomashaener @damiansteiger