Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake Components During Discovery #138

Closed
srueg opened this issue Jul 8, 2020 · 3 comments · Fixed by #160
Closed

Fake Components During Discovery #138

srueg opened this issue Jul 8, 2020 · 3 comments · Fixed by #160
Labels
enhancement New feature or request RFC Request for Comments

Comments

@srueg
Copy link
Contributor

srueg commented Jul 8, 2020

Context

During discovery, all components are being cloned, even ones that are not included for the current cluster. Faking the components in this step could improve performance a lot. Additionally would it lower the side effects components can have to each other.
After the inventory is built, the actually included components of a cluster can be cloned.

@srueg
Copy link
Contributor Author

srueg commented Jul 24, 2020

Using the reclass "Ignore class not found" feature we might not even have to fake the component classes: https://github.com/salt-formulas/reclass/blob/develop/README-extensions.rst#ignore-class-not-found

@srueg
Copy link
Contributor Author

srueg commented Aug 12, 2020

The problem with this approach is, that if the inventory references values from a component defaults.yml it will break.
For example in eks.yml:

parameters:
  synsights:
    alertmanager:
      config:
        route:
          # Set default receiver to Signalilo
          receiver: ${synsights_signalilo:alertmanager_receiver:name}

This will fail because the signalilo component is not yet available.

@srueg
Copy link
Contributor Author

srueg commented Aug 12, 2020

Started a WIP PR to implement this approach: #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RFC Request for Comments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant