move stringIsParsableInteger from ERXExtensions to ERXStringUtilities

wocommunity · May 1, 2012 · d74b7d9 · d74b7d9
1 parent 0168864
commit d74b7d9
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/Frameworks/Core/ERExtensions/Sources/er/extensions/ERXExtensions.java b/Frameworks/Core/ERExtensions/Sources/er/extensions/ERXExtensions.java
@@ -702,9 +702,9 @@ public static boolean safeDifferent(Object v1, Object v2) {
      * an integer.
      * @param s string to be parsed
      * @return if the string can be parsed into an int
+     * @deprecated use {@link ERXStringUtilities#stringIsParseableInteger(String)}
      */
-    // FIXME: Should return false if the object is null.
-    // MOVEME: ERXStringUtilities
+    @Deprecated
     public static boolean stringIsParseableInteger(String s) {
         try {
             Integer.parseInt(s);

diff --git a/Frameworks/Core/ERExtensions/Sources/er/extensions/foundation/ERXStringUtilities.java b/Frameworks/Core/ERExtensions/Sources/er/extensions/foundation/ERXStringUtilities.java
@@ -415,6 +415,22 @@ public static Integer integerWithString(String s) {
         return null;
     }
 
+    /**
+     * Tests if a given string object can be parsed into
+     * an integer.
+     * @param s string to be parsed
+     * @return <code>true</code> if the string is not <code>null</code>
+     *      and can be parsed to an int
+     */
+    public static boolean stringIsParseableInteger(String s) {
+        try {
+            Integer.parseInt(s);
+            return true;
+        } catch (NumberFormatException e) {
+            return false;
+        }
+    }
+
     /**
      * Wrapper for {@link Integer#valueOf(String)} that catches
      * the NumberFormatException.