-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Centralized Default Position for Handle Panel: #42
Comments
Was this what we where talking about @JamesSingleton 👀 |
@meglerhagen yea, the error you're getting on the But also the direct middle is going to be different for every screen size, so it might be better to just determine how wide you want them. https://github.com/bvaughn/react-resizable-panels/blob/main/packages/react-resizable-panels/README.md#panel Also, it looks like there is a |
I have tried, and tried @JamesSingleton . Maybe im dumb, but cant get this to work 🍅 |
I would like to work on this |
Go insane @miralsuthar ✨ 😄 |
The values is from a project that was before, i think this is changed. You can just experiment and see if it works. Thats my main concern right now. Thanks for the comment. |
Title
Currently, the right handle panel is locked to the right side. The default position should be centered.
Improvement Description
The panel should be split, something like this picture on default.
Proposed Solution
We need to look at the documentation code to see what we can find. I think the picture down should guide is in the right direction.
Additional Context
Under you is screenshot from Shadcn and our project
Shadcn:
Our application:
Under you can see the diffrence from Shadcn code and our. Im getting a error message for this:
The text was updated successfully, but these errors were encountered: