Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: White blank space issue when resizing internal UI component (on right side) #68

Closed
veerbal1 opened this issue Jan 22, 2024 · 13 comments · Fixed by #73
Closed
Assignees
Labels
🐛 bug Something isn't working

Comments

@veerbal1
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'dashboard/transactions' & 'dashboard/accounts'
  2. Decrease right section width as minimum as possible - using resizable button
  3. Now try to scroll horizontally.
  4. See window get white blank space on right side and causing scrolling on x-axis

Expected behavior
It should not scroll when we decrease width using resize button our internal UI components

Screenshots
Screenshot 2024-01-22 at 3 11 21 PM

Desktop (please complete the following information):

  • OS: MacOS Intel Chip (Viewport 1440x900)
  • Browser: Arc
@Codehagen
Copy link
Member

Ahh, yeah thats a problem! We need to look into it. Thanks for the headsup ✨

@codingsagar
Copy link
Contributor

Hey, I will be happy to work on this. Can you please assign this to me.
@veerbal1 will you be working on this ?

@Codehagen
Copy link
Member

So im assigng it to you both. If there is something please contact me :)

@Codehagen Codehagen added the 🐛 bug Something isn't working label Jan 23, 2024
@codingsagar codingsagar removed their assignment Jan 23, 2024
@codingsagar
Copy link
Contributor

Sorry I accidentally unassigned this task to me. Please reassign it, I am starting to work on this. Thanks !

veerbal1 added a commit to veerbal1/projectx that referenced this issue Jan 23, 2024
…ce issue

Now there is no longer scroll issue while resizing components

projectx-codehagen#68
@veerbal1
Copy link
Contributor Author

@meglerhagen Please check the PR and the code changes. It was working good on my side. Kindly test on your side if possible.

@Codehagen
Copy link
Member

Hello @codingsagar - Could you check the PR to see if the issue was solved at your end? Could not replicate the error.

@Codehagen Codehagen changed the title Horizontal scrolling and white blank space issue when resizing internal UI component (on right side) Feature: Horizontal scrolling and white blank space issue when resizing internal UI component (on right side) Jan 23, 2024
@Codehagen Codehagen changed the title Feature: Horizontal scrolling and white blank space issue when resizing internal UI component (on right side) Feature: White blank space issue when resizing internal UI component (on right side) Jan 23, 2024
@codingsagar
Copy link
Contributor

Sure, I'll check the PR. Will get back to you soon.

@Codehagen
Copy link
Member

Nice, tell me when you have checked 👍

@codingsagar
Copy link
Contributor

Hey, I tried a lot to replicate the error on my machine too but couldn't replicate. Tried with the same display size (1440x900) in the dev tools which was given in the issue itself and even tried to change machines resolution. Everything is working fine and responsive as much as I checked. Maybe this has to do something with the Arc Browser because of it there might be some issue.

@Codehagen
Copy link
Member

I also think the Arc browser is the problem @codingsagar. Can you try with another browser @veerbal1 ?

@veerbal1
Copy link
Contributor Author

I tested the live link https://projectx-eight-gilt.vercel.app/dashboard/transactions on Chrome, Mac Safari, Firefox and Arc browser. The scrolling issue exists in all browsers except Firefox.

Chrome -

Screen.Recording.2024-01-24.at.11.59.53.AM.mov

Mac Safari -

Screen.Recording.2024-01-24.at.12.02.44.PM.mov

Arc -

Screen.Recording.2024-01-24.at.12.06.48.PM.mov

Firefox was OK

After fixing in this PR #73

Screen.Recording.2024-01-24.at.12.09.22.PM.mov

Screen dimensions -
Screenshot 2024-01-24 at 12 18 54 PM

@codingsagar
Copy link
Contributor

Hey @meglerhagen I again tried to replicate the error on Microsoft edge and I could now replicate the error. Previously I was using firefox in which its working fine. I checked the PR and after testing on my machine too its working fine. I think we can merge the PR.

@Codehagen
Copy link
Member

Thank you, merging now then @veerbal1 @codingsagar

Codehagen pushed a commit that referenced this issue Jan 24, 2024
Now there is no longer scroll issue while resizing components

#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants