Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: More stock cards on Investment page #78

Closed
Codehagen opened this issue Jan 23, 2024 · 6 comments 路 Fixed by #81
Closed

Feature: More stock cards on Investment page #78

Codehagen opened this issue Jan 23, 2024 · 6 comments 路 Fixed by #81
Assignees
Labels
馃挕 feature Requests for new features or enhancements. 馃殌 Good first issue Good for newcomers

Comments

@Codehagen
Copy link
Member

Type of feature

馃挕 Feature

Current behavior

We need more cards to get mapped to the row with relevant stocks.

image

Suggested solution

No response

Additional context

No response

@Codehagen Codehagen added 馃殌 Good first issue Good for newcomers 馃挕 feature Requests for new features or enhancements. labels Jan 23, 2024
@codingsagar
Copy link
Contributor

I can work on this one, what is exactly we need to do ?

@Codehagen
Copy link
Member Author

I just need more stocks to be mapped. Apple, Google, Amazon etc. Just take 7 stocks that can fit :)

@codingsagar
Copy link
Contributor

Got it! I'll few more stocks to the list.

@codingsagar
Copy link
Contributor

image

As we wanted more stocks to the list when we click on the stock they are shown in the right side. I just added more stock to the investment data in the data.tsx inside the /investment dir. Is this right or we had to do it some other way.

I added the stocks like this
image

@Codehagen
Copy link
Member Author

Yeah, that sounds like a plan. You can make PR for it and i can check it out?

@codingsagar
Copy link
Contributor

Created a PR for this, please check and let me know if something is wrong I just added more data in the data.tsx from where other 2 cards data was coming. Had a confusion isn't it fake data for development and how will the real data come. Trying to understand the project more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃挕 feature Requests for new features or enhancements. 馃殌 Good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants