Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): allow specifying git identity for workflows #1151

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Oct 19, 2021

The workflowGitIdentity option can be used in Node.js projects to determine the default git identity of GitHub workflows.

This will automatically get applied to build and upgrade workflows.

NOTE: To configure the git identity for Go publishing, use gitUserName and gitUserEmail in GoPublishOptions.

Resolves #1147


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The `workflowGitIdentity` option can be used in Node.js projects to determine the default git identity of GitHub workflows.

This will automatically get applied to build and upgrade workflows.

NOTE: To configure the git identity for Go publishing, use `gitUserName` and `gitUserEmail` in `GoPublishOptions`.
@mergify mergify bot added the contribution/core ⚙️ used by automation label Oct 19, 2021
@eladb eladb requested a review from Chriscbr October 19, 2021 15:58
@Chriscbr Chriscbr added the pr/do-not-merge ⚙️ used by automation label Oct 19, 2021
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one optional suggestion (adding pr/do-not-merge in case you want to address)

src/node-project.ts Show resolved Hide resolved
@eladb eladb merged commit 63f89f0 into main Oct 20, 2021
@eladb eladb deleted the benisrae/git-identity branch October 20, 2021 07:04
@skorfmann
Copy link
Contributor

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core ⚙️ used by automation pr/do-not-merge ⚙️ used by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Github Identity Configurable
3 participants