Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decouple docgen from compile task #1154

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

Chriscbr
Copy link
Contributor

Closes #1153


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Chriscbr Chriscbr requested a review from eladb October 19, 2021 22:27
@mergify mergify bot added the contribution/core ⚙️ used by automation label Oct 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1154 (014d8bb) into main (377966e) will increase coverage by 6.68%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
+ Coverage   78.46%   85.15%   +6.68%     
==========================================
  Files          88      115      +27     
  Lines        3181     4445    +1264     
  Branches      809     1182     +373     
==========================================
+ Hits         2496     3785    +1289     
+ Misses        683      660      -23     
+ Partials        2        0       -2     
Impacted Files Coverage Δ
src/_resolve.ts 96.87% <ø> (+0.57%) ⬆️
src/awscdk-app-ts.ts 88.63% <ø> (+72.45%) ⬆️
src/awscdk-construct.ts 86.11% <ø> (+71.82%) ⬆️
src/cdk8s-app-ts.ts 90.00% <ø> (-1.90%) ⬇️
src/cdk8s-construct.ts 93.75% <ø> (+60.41%) ⬆️
src/cdktf-construct.ts 87.50% <ø> (ø)
src/clobber.ts 100.00% <ø> (ø)
src/deps/dependencies.ts 100.00% <ø> (ø)
src/eslint.ts 89.36% <ø> (+13.49%) ⬆️
src/file.ts 97.05% <ø> (+0.08%) ⬆️
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbbe29...014d8bb. Read the comment docs.

@eladb eladb merged commit 996f160 into main Oct 20, 2021
@eladb eladb deleted the rybickic/decouple-docgen branch October 20, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core ⚙️ used by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple docgen task from compile task
3 participants