fix(awscdk): integ tests are still not working for libraries #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
commented
Dec 7, 2021
| * | ||
| * @returns a copy (cannot be modified) or undefined if there is no match | ||
| */ | ||
| public tryGetDependency(name: string, type?: DependencyType): Dependency | undefined { |
There was a problem hiding this comment.
@Chriscbr I saw you also added this, but I get credit for also adding a test :-)
Chriscbr
approved these changes
Dec 7, 2021
Codecov Report
@@ Coverage Diff @@
## main #1302 +/- ##
==========================================
+ Coverage 78.46% 87.65% +9.19%
==========================================
Files 88 127 +39
Lines 3181 4877 +1696
Branches 809 1153 +344
==========================================
+ Hits 2496 4275 +1779
+ Misses 683 602 -81
+ Partials 2 0 -2
Continue to review full report at Codecov.
|
|
Thanks for your quick response and the fix. 🚀 Issue resolved. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Pswitch forts-nodeshould have appeared before the entrypoint.tryGetDependency()Fixes #1300
Fixes #1299 (again)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.