Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): bun setup for javascript workflows #3176

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

abdsahin
Copy link
Contributor

@abdsahin abdsahin commented Dec 14, 2023

Bun added as a package manager but the workflows are still using NodeJS. This is to fix this.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.34%. Comparing base (f41cf3c) to head (a5d3488).
Report is 2 commits behind head on main.

Files Patch % Lines
src/cdk/jsii-project.ts 20.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3176      +/-   ##
==========================================
+ Coverage   96.32%   96.34%   +0.02%     
==========================================
  Files         191      192       +1     
  Lines       37407    37463      +56     
  Branches     3489     3496       +7     
==========================================
+ Hits        36032    36094      +62     
+ Misses       1375     1369       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrgrain mrgrain marked this pull request as ready for review March 25, 2024 09:39
@mrgrain mrgrain changed the title fix(javascript): added bun setup for javascript workflows fix(bun): bun setup for javascript workflows Mar 25, 2024
@mrgrain mrgrain changed the title fix(bun): bun setup for javascript workflows fix(javascript): bun setup for javascript workflows Mar 25, 2024
@mrgrain
Copy link
Contributor

mrgrain commented Mar 25, 2024

@Mergifyio update

Copy link
Contributor

mergify bot commented Mar 25, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

@mergify mergify bot merged commit d3ba33e into projen:main Mar 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants