feat(release): publish JSII Python Artifacts to AWS CodeArtifact #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothymathison
commented
Mar 22, 2024
Comment on lines
+538
to
+539
| name: "Generate CodeArtifact Token", | ||
| run: `echo "TWINE_PASSWORD=$(aws codeartifact get-authorization-token --domain ${domain} --domain-owner ${account} --region ${region} --query authorizationToken --output text)" >> $GITHUB_ENV`, |
There was a problem hiding this comment.
Unfortunately publib does not natively support codeartifact for python like it does for npm. So had to add this step.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 191 191
Lines 37407 37485 +78
Branches 3489 3500 +11
=======================================
+ Hits 36032 36108 +76
- Misses 1375 1377 +2 ☔ View full report in Codecov by Sentry. |
mrgrain
reviewed
Mar 25, 2024
src/release/publisher.ts
Outdated
| * @param url Of code artifact domain | ||
| * @returns domain, account, and region of code artifact domain | ||
| */ | ||
| export function awsCodeArtifactInfoFromUrl(url?: string): AwsCodeArtifactInfo { |
There was a problem hiding this comment.
No need for this to be exported.
Suggested change
| export function awsCodeArtifactInfoFromUrl(url?: string): AwsCodeArtifactInfo { | |
| function awsCodeArtifactInfoFromUrl(url?: string): AwsCodeArtifactInfo { |
mrgrain
reviewed
Mar 25, 2024
src/release/publisher.ts
Outdated
| /** | ||
| * Info extracted from AWS CodeArtifact URL | ||
| */ | ||
| export interface AwsCodeArtifactInfo { |
There was a problem hiding this comment.
No need for this to be exported and part of the public API.
Suggested change
| export interface AwsCodeArtifactInfo { | |
| interface AwsCodeArtifactInfo { |
mrgrain
requested changes
Mar 25, 2024
mrgrain
changed the title
mrgrain
changed the title
mrgrain
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes pypi publisher job support targeting AWS CodeArtifact. Re-uses the
CodeArtifactOptionsalready added to support publishing of NPM packages to CodeArtifact.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.