Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integ tests on private cdk lib fail since two days - ideas how to debug welcome #3536

Closed
markussiebert opened this issue Apr 26, 2024 · 6 comments
Labels
needs-investigation Resolving this issue required further investigation

Comments

@markussiebert
Copy link

Since two days we see the integ tests failing in our ci pipelines. It looks like:

👾 release » build » test » eslint | eslint --ext .ts,.tsx --fix --no-error-on-unmatched-pattern  src test build-tools projenrc .projenrc.ts
👾 release » build » test » integ:EksAddonClusterAutoscaler:assert | [ -d "test/EksAddons/EksAddonClusterAutoscaler.integ.snapshot" ] || (echo "No snapshot available for integration test 'EksAddonClusterAutoscaler'. Run 'projen integ:EksAddonClusterAutoscaler:deploy' to capture." && exit 1)
👾 release » build » test » integ:EksAddonClusterAutoscaler:assert | cdk synth --app "ts-node -P tsconfig.dev.json test/EksAddons/EksAddonClusterAutoscaler.integ.ts" --no-notices --no-version-reporting --no-asset-metadata --no-path-metadata -o test/EksAddons/.tmp/EksAddonClusterAutoscaler.integ/assert.cdk.out > /dev/null
👾 release » build » test » integ:EksAddonClusterAutoscaler:assert | diff -r -x asset.* -x cdk.out -x manifest.json -x tree.json test/EksAddons/EksAddonClusterAutoscaler.integ.snapshot/ test/EksAddons/.tmp/EksAddonClusterAutoscaler.integ/assert.cdk.out/
diff: test/EksAddons/.tmp/EksAddonClusterAutoscaler.integ/assert.cdk.out/: No such file or directory
👾 Task "release » build » test » integ:EksAddonClusterAutoscaler:assert" failed when executing "diff -r -x asset.* -x cdk.out -x manifest.json -x tree.json test/EksAddons/EksAddonClusterAutoscaler.integ.snapshot/ test/EksAddons/.tmp/EksAddonClusterAutoscaler.integ/assert.cdk.out/" (cwd: /builds/a/cdk/eks)
error Command failed with exit code 1.

The thing I don't understand is, why is this happening - even pipelines that already were successfull fail now on rerunning them. The day things started to fail had no coincedence with changes in our ci environment - or codechanges - as mentioned, we see this failure even on builds that already succeeded.

Locally everything works fine - no errors.

Do you have an idea how to debug this, or what can cause this behaviour?

@mrgrain
Copy link
Contributor

mrgrain commented Apr 26, 2024

With no changes in your codebase? 🤯

To me the likeliest reasons seems that this command stops producing the correct output and fails silently:

cdk synth --app "ts-node -P tsconfig.dev.json test/EksAddons/EksAddonClusterAutoscaler.integ.ts" --no-notices --no-version-reporting --no-asset-metadata --no-path-metadata -o test/EksAddons/.tmp/EksAddonClusterAutoscaler.integ/assert.cdk.out > /dev/null

When you run this locally, can you make sure the .tmp folder is removed first?

@markussiebert
Copy link
Author

Yes - after digging some time in the ci container it seems cdk is not working at all - the command finishes with exit code 0 even if the integ.test.ts is deleted ... if I change it to cdk deploy, it's finished in no time with no output and exit code 0. of course no cdk.out is created

@mrgrain
Copy link
Contributor

mrgrain commented Apr 27, 2024

Very odd! I would see that the app command does without the cdk cli. Sometimes that's giving a better error message. (That's the ts-node...)

@mrgrain mrgrain added the needs-investigation Resolving this issue required further investigation label Apr 29, 2024
@mrgrain
Copy link
Contributor

mrgrain commented May 25, 2024

@markussiebert Did you ever get to the bottom of this?

@markussiebert
Copy link
Author

No was debugging in the gitlab executor pod - finally switched node image and it worked agin. Hadn't pinned the char, so maybe there was a change in the node image we used then...

@mrgrain
Copy link
Contributor

mrgrain commented May 26, 2024

Okay. Closing as this seems to be an issue with Node or the AWS CDK.

@mrgrain mrgrain closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-investigation Resolving this issue required further investigation
Projects
None yet
Development

No branches or pull requests

2 participants