fix: some tasks fail on Windows due to missing shell commands #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
May 12, 2021
|
@eladb I also tried to "refactor" by extracting the code, but it becomes gnarly so I'd rather let it be the way it is. |
eladb
reviewed
May 12, 2021
eladb
changed the title
eladb
approved these changes
May 13, 2021
Codecov Report
@@ Coverage Diff @@
## main #781 +/- ##
==========================================
+ Coverage 78.46% 82.67% +4.20%
==========================================
Files 88 96 +8
Lines 3181 3544 +363
Branches 809 793 -16
==========================================
+ Hits 2496 2930 +434
+ Misses 683 612 -71
Partials 2 2
Continue to review full report at Codecov.
|
|
Oh man, this extremely frustrating. We ditched projen because we are on a mixed team with mostly Windows developers. Overall kind of sad, because projen would help so much, especially inexperienced TypeScript/Javascript folks on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address #452 by wrapping the commands 'rm', 'mkdir' and 'mv' with
shx.A whitelist of commands is maintained in the task runtime.
@eladb Is this what you had in mind when commenting on #540?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.