fix(deps): frozen installation fails during ugprade workflow #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
May 18, 2021
src/upgrade-dependencies.ts
Outdated
|
|
||
| // we use projen to install the dependencies and thus update the lock file, | ||
| // so we need to make it think its not running inside CI. | ||
| task.exec(`CI=0 ${this._project.projenCommand}`); |
There was a problem hiding this comment.
Suggested change
| task.exec(`CI=0 ${this._project.projenCommand}`); | |
| task.exec(this._project.projenCommand, { | |
| env: { CI: '0' } | |
| }); |
eladb
reviewed
May 18, 2021
| @@ -118,7 +118,11 @@ export class UpgradeDependencies extends Component { | |||
| } | |||
|
|
|||
| task.exec(ncuCommand.join(' ')); | |||
| task.exec(this._project.package.renderInstallCommand(false)); | |||
There was a problem hiding this comment.
Does that mean we can make this private again?
Codecov Report
@@ Coverage Diff @@
## main #801 +/- ##
==========================================
+ Coverage 78.46% 83.59% +5.12%
==========================================
Files 88 96 +8
Lines 3181 3620 +439
Branches 809 805 -4
==========================================
+ Hits 2496 3026 +530
+ Misses 683 593 -90
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
eladb
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #800.
The problem was that projen itself can change
package.jsonfiles due to its own requirements.Which causes the
package.jsonfile to change after runningyarn install- and a subsequent frozen installation would fail.This PR uses projen itself to install the dependencies and update the lock file, so this happens after all
package.jsonmutations have happened.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.