Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): use projen token for deps workflow if defined #846

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jun 1, 2021

If projenUpgradeSecret is defined, use it for the normal dependency upgrade workflow and not just for the projen upgrade workflow. This is useful if dep changes require workflow changes


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

If `projenUpgradeSecret` is defined, use it for the normal dependency upgrade workflow and not just for the projen upgrade workflow. This is useful if dep changes require workflow changes
@mergify mergify bot added the contribution/core ⚙️ used by automation label Jun 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #846 (ecbd3e5) into main (377966e) will increase coverage by 4.95%.
The diff coverage is 76.55%.

❗ Current head ecbd3e5 differs from pull request most recent head 9f9422c. Consider uploading reports for the commit 9f9422c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
+ Coverage   78.46%   83.42%   +4.95%     
==========================================
  Files          88      101      +13     
  Lines        3181     3861     +680     
  Branches      809      903      +94     
==========================================
+ Hits         2496     3221     +725     
+ Misses        683      637      -46     
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/cdk8s-app-ts.ts 91.89% <ø> (ø)
src/cdk8s-construct.ts 33.33% <ø> (ø)
src/file.ts 97.14% <ø> (+0.17%) ⬆️
src/github/auto-merge.ts 92.85% <ø> (-7.15%) ⬇️
src/github/dependabot.ts 96.77% <ø> (ø)
src/github/index.ts 100.00% <ø> (ø)
src/java/pom.ts 93.84% <ø> (ø)
src/object-file.ts 100.00% <ø> (+2.38%) ⬆️
src/tasks/model.ts 100.00% <ø> (ø)
src/tasks/runtime.ts 14.54% <16.66%> (-1.76%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f3602...9f9422c. Read the comment docs.

@eladb eladb merged commit 1181275 into main Jun 1, 2021
@eladb eladb deleted the benisrae/deps-projen-token branch June 1, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core ⚙️ used by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants