Fix issue with compiling using API 21 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| private void setUpLayoutFactories() { | ||
| // If we are HC+ we get and set Factory2 otherwise we just wrap Factory1 | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) { |
There was a problem hiding this comment.
we are using minSdkVersion 14. should this be lower?
There was a problem hiding this comment.
This line was taken from Calligraphy, which supports sdk 7. Right now we need sdk 14 because of the animations, but we can keep this to fix issue #1.
mluedke2
added a commit
that referenced
this pull request
Feb 17, 2015
Fix issue with compiling using API 21
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied a lot of work from the Calligraphy project to fix issue #7.
It also appears that wrapping the Context multiple times no longer works, so to use Calligraphy in conjunction a work around was created.
Example project now uses the AppCompat library.