Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] ServiceMonitor needs separate scheme parameters #3802

Closed
tynsh opened this issue Sep 14, 2023 · 1 comment · Fixed by #3815
Closed

[kube-prometheus-stack] ServiceMonitor needs separate scheme parameters #3802

tynsh opened this issue Sep 14, 2023 · 1 comment · Fixed by #3815

Comments

@tynsh
Copy link

tynsh commented Sep 14, 2023

Hi,

currently the prometheus config reloader does not support https at the metrics endpoint. As both the config reloader and prometheus/alertmanager share the same scheme value, when activating https on the serviceMonitor scraping of will fail on the reloader container. This issue exists for the prometheus service monitor as well as the one for alertmanager. Here are the relevant lines for alertmanager:

https://github.com/prometheus-community/helm-charts/blob/723cfad365d5c55b84162d4a5f11294ea736ca54/charts/kube-
prometheus-stack/templates/alertmanager/servicemonitor.yaml#L57-L59

@n1kofr
Copy link
Contributor

n1kofr commented Sep 15, 2023

Facing the same issue for prometheus config reloader. Scrapping config-reloader is failing with wrong scheme issue as config-reloader ServiceMonitor is using the same scheme as prometheus.

{{- if .Values.prometheus.serviceMonitor.scheme }}
scheme: {{ .Values.prometheus.serviceMonitor.scheme }}
{{- end }}

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants